Repository navigation
fix: allow an escaped backslash at the end of a Value regex - #154
Open
OverloadedTech wants to merge 1 commit into
Open
OverloadedTech wants to merge 1 commit into
OverloadedTech wants to merge 1 commit into
Conversation
The check for an escaped closing ')' only looked at the character before it, so a regex ending in an escaped backslash like ([A-Z]:\\) was rejected as not being inside a '()' pair. Count the backslashes instead and only reject an odd number.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Value regex that ends in an escaped backslash is rejected, even though it's a valid regex:
fails with
Value '([A-Z]:\\)' must be contained within a '()' pair.The check added in #99 rejects the regex if the character before the last
)is a backslash, to catch an escaped\). But in\\)the backslash is itself escaped and the)is a normal one. Now it counts the backslashes before the final)and only rejects an odd number, so(boo)hoo\)and(boo)hoo\\\)are still errors.Added cases to
testFSMValue, the new one fails without the change.pytest tests: 113 passed. Also ran a small template with that Value through thetextfsmcommand, it parsesC:\/D:\lines now.